apps/playground-web/src/app/insight/[blueprint_slug]/blueprint-playground.client.tsx (1)

525-526: Consider the impact of placeholder logic change.

The placeholder logic has been simplified from a context-aware URL-based calculation to using param.description || param.name. While this works well for the aggregate parameter, it might reduce the user experience for path parameters where the original logic provided more meaningful placeholders like {param_name} or :param_name.

Consider preserving the original placeholder logic for non-aggregate parameters:

-                            placeholder={param.description || param.name}
+                            placeholder={param.name === "aggregate" ? (param.description || param.name) : (url.includes(`{${param.name}}`) ? `{${param.name}}` : url.includes(`:${param.name}`) ? `:${param.name}` : "Value")}

Or extract the placeholder logic into a helper function for better maintainability.

apps/playground-web/src/app/insight/[blueprint_slug]/aggregate-parameter-input.client.tsx (2)

138-148: Consider more flexible endpoint matching.

The current exact string matching for endpoint paths is brittle and won't handle dynamic path segments or variations in endpoint structure.

Consider implementing more flexible pattern matching:

-const ENDPOINT_SPECIFIC_PRESETS: Record<string, Preset[]> = {
-  "/v1/transactions": GENERAL_TRANSACTIONS_PRESETS,
-  "/v1/wallets/{wallet_address}/transactions": WALLET_TRANSACTIONS_PRESETS,
-  "/v1/events": EVENTS_PRESETS,
-  "/v1/blocks": BLOCKS_PRESETS,
-  // Add more endpoint paths and their specific presets here
-};
+const ENDPOINT_PATTERNS: Array<{pattern: RegExp, presets: Preset[]}> = [
+  { pattern: /\/v1\/transactions$/, presets: GENERAL_TRANSACTIONS_PRESETS },
+  { pattern: /\/v1\/wallets\/[^/]+\/transactions/, presets: WALLET_TRANSACTIONS_PRESETS },
+  { pattern: /\/v1\/events/, presets: EVENTS_PRESETS },
+  { pattern: /\/v1\/blocks/, presets: BLOCKS_PRESETS },
+];

 function getAggregatePresets(endpointPath: string): Preset[] {
-  return ENDPOINT_SPECIFIC_PRESETS[endpointPath] || DEFAULT_AGGREGATE_PRESETS;
+  const match = ENDPOINT_PATTERNS.find(({pattern}) => pattern.test(endpointPath));
+  return match?.presets || DEFAULT_AGGREGATE_PRESETS;
 }

---

180-186: Consider edge case handling for preset selection.

The current implementation only calls onChange when selectedValue is truthy, but consider what happens if a user wants to clear their selection.

Consider adding a "Clear" option or handling empty selection:

        onValueChange={(selectedValue) => {
-          if (selectedValue) {
-            onChange({ target: { value: selectedValue } });
-          }
+          onChange({ target: { value: selectedValue || "" } });
        }}

Or add a clear option to the select dropdown.

apps/playground-web/src/app/insight/[blueprint_slug]/aggregate-parameter-input.client.tsx (1)

19-37: 🛠️ Refactor suggestion

Improve default preset usability.

The default presets contain placeholder text like your_field_here which requires user modification. This might confuse users who expect working presets.

Consider either:

1. Removing the custom field presets from defaults and only including them in endpoint-specific collections where field names are known
2. Adding clear documentation or help text indicating these are templates

 const DEFAULT_AGGREGATE_PRESETS: Preset[] = [
   { label: "Count All Items", value: "count() AS count_all" },
   { label: "Sum (gas_used)", value: "sum(gas_used) AS total_gas_used" },
   { label: "Average (gas_used)", value: "avg(gas_used) AS avg_gas_used" },
   { label: "Min (gas_used)", value: "min(gas_used) AS min_gas_used" },
   { label: "Max (gas_used)", value: "max(gas_used) AS max_gas_used" },
-  // Presets for a user-defined field
-  {
-    label: "Count (custom field)",
-    value: "count(your_field_here) AS count_custom",
-  },
-  { label: "Sum (custom field)", value: "sum(your_field_here) AS sum_custom" },
-  {
-    label: "Average (custom field)",
-    value: "avg(your_field_here) AS avg_custom",
-  },
-  { label: "Min (custom field)", value: "min(your_field_here) AS min_custom" },
-  { label: "Max (custom field)", value: "max(your_field_here) AS max_custom" },
 ];

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

const DEFAULT_AGGREGATE_PRESETS: Preset[] = [
  { label: "Count All Items", value: "count() AS count_all" },
  { label: "Sum (gas_used)", value: "sum(gas_used) AS total_gas_used" },
  { label: "Average (gas_used)", value: "avg(gas_used) AS avg_gas_used" },
  { label: "Min (gas_used)", value: "min(gas_used) AS min_gas_used" },
  { label: "Max (gas_used)", value: "max(gas_used) AS max_gas_used" },
];

🤖 Prompt for AI Agents

In
apps/playground-web/src/app/insight/[blueprint_slug]/aggregate-parameter-input.client.tsx
around lines 19 to 37, the default aggregate presets include placeholders like
"your_field_here" which can confuse users expecting functional presets. To fix
this, remove these custom field presets from the default list and instead
include them only in endpoint-specific preset collections where actual field
names are known, or alternatively add clear inline comments or UI help text
indicating these presets are templates requiring user modification.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro